How to Submit FMAC Code and Bug Fixes

How to Submit FMAC Code And Bug Fixes

This procedure describes how to submit new code and bug-fix code changes to the FMAC project. The FMAC project intends to follow the OpenSolaris Development Process as much as makes sense.

1. Ensure that you have a Sun Contributor Agreement (SCA) on file or are a Sun employee.

For information about the SCA, see the SCA FAQ.

1. Ensure that the submitted code is in the following state:

• Kernel code is lint clean
• Code passes cstyle
• Header files pass hdrchk

Note - Because FMAC is a development project in its own repository, it does not need to meet all the requirements that are necessary to integrate into the ONNV repository. This does not mean that we will drop our quality needs, but it does allow for more wiggle room.

When the FMAC project is ready, we plan to use the OpenSolaris Integration Procedure to integrate into ONNV and we can't let things go until the end or we will be stuck in a cleanup spiral.

1. Submit a code review in one of the following ways:

• Send a diff of the code (hg diff -g) to the fmac-discuss@opensolaris.org list.

• Post a webrev to http://cr.opensolaris.org, which is preferred for complex changes, and send a pointer to the webrev to the fmac-discuss list.

If submitting a fix for a bug filed at defect.opensolaris.org, include the bug number(s) in the commit message by using the following style:

       bug-number bug-summary

For example:

       2131 checkpolicy produces different policy files on x86 & SPARC

1. Obtain submission approvals from FMAC contributors.

One or more FMAC contributors must approve the submission before it can be pushed to the repository. The submission must be reviewed by at least one FMAC contributor other than the contributor.

1. Push the changes to the repository.

Do one of the following depending on whether you are permitted to commit changes to the FMAC Mercurial repository:

• If permitted, push your changes to the FMAC repository at hg.opensolaris.org/hg/fmac/fmac-gate.

• If not permitted, the FMAC contributor who approved your submission will commit your changes first to his repository and then to the FMAC repository.

To receive repository changeset notifications, subscribe to the fmac-notify@opensolaris.org list.