Code Review

Crossbow Code Review Phase I
- Userland library libdladm
- Commands flowadm, acctadm, dladm

Code Review Phase I Webrev

Crossbow Code Review Phase II

The Crossbow Code Review 2 Webrev is ready.

Please use this template for the format of comments.

We're seeking a code review for the following areas of the code:

- MAC layer
- MAC client interface - MAC driver interfaces - Hybrid I/O support - Resource management and allocation - Packet scheduling - Software classification - Soft-rings, SRS, and polling - Transmit flow control and fanout - Promiscuous mode

- Other GLDv3 changes
- vnic - DLS - DLD - Softmac

- IP changes

- e1000g driver

This is still work in progress because we have bugs to fix.
Other issues are expected as we're gearing up the stress testing.
However, given the size of a project such as Crossbow, it is not possible
to wait until the final bits are 100% ready for integration, and the team
judged that a phased review is more efficient for both the team and the
community. We will conduct a subsequent review against the current Crossbow
code base, so reviewers will get to review what have changed since this
round.

Below are know design and code issues. We intend to fix all code
issues before integration. Some of the design issues may be delayed
for a subsequent integration (due to possible risk involved, and to
impact on other projects such as Datapath re-factoring)</b>.

Known Code Issues

- The Setup of links and Flows is not implemented to the team's satisfaction.  Significant changes are expected specifically in mac_datapath_setup.c. The file is provided for reviewers to understand the logic, however, we are not seeking comments about this file, and a subsequent review will cover it.

- Further simplification are planned for the way the MAC layer caches link properties and retrieves them, including the code path for setting the properties (they seem to be unnecessarily long).

- Debug helpers (extra mdb walkers, dtrace provider) and more kstats will be added for putback 1 itself and reviewed in next round.

Known Design Issues

- DLS bypass for IPv4 only and asymmetric IPv4 vs IPv6 datapath (RFE 6719435 Finish the DLS bypass work). The RFE entails bringing a full SAP classifer in MAC, deal with mac_header_info for v6 while preserving packet chains and making squeue polling symmetric for both v4 and v6.  Since there is sunstantial of overlap with IP datapath refactoring project, this RFE will be done in datapath project gate after it merges with Crossbow putback 1.

- Dynamic Resources Allocation for Rx/Tx rings and DMA channels. Work in progress in conjunction with Sun labs and will be part of Crossbow putback 2.

- Multiple threads per link and thread binding logic. Needs investigation and some of it will be handled as part of dynamic resource allocation. Will be addressed in putback 2.

Crossbow Code Review Phase III

The Crossbow Code Review 3 Webrev is ready. The changes to cover in this third phase are under webrev.PhaseIII. webrev.onnv_94 is the complete set of changes of the Crossbow project, provided for reference.

We're seeking a code review for the following areas of the code:

- VLANs
- Link Aggregations
- Xen
- All drivers (excluding e1000g)
- MAC datapath setup