Clearview IP Tunneling Code-Review

Welcome to the Clearview IP Tunneling code-review. Comments should be sent to clearview-discuss@opensolaris.org before August 12th.

• Initial ON webrev: http://cr.opensolaris.org/seb/clearview-iptun-cr/
• Updated ON webrev: http://cr.opensolaris.org/seb/clearview-iptun-cr2/ (diffs against previous webrev)
• SFW webrev: http://cr.opensolaris.org/seb/clearview-iptun-sfw-cr/

 A code-review repo along with cscope database is available at /net/zhadum.east/export/ws/clearview/clearview-iptun-cr/ (or clearview-iptun-cr2 for the repo corresponding to the updated webrev above) for those who have access to Sun's internal network.

 Reviewers may wish to focus on a specific area to narrow down their review. Here is a suggested breakdown by area:

• IP tunnel configuration commands (sowmini)
• dlmgmtd datalink management daemon (yun)
• libraries (sowmini, girishmg)
• miscellaneous supporting utilities (vassun08)
• iptun driver (meem, nordmark)
• IPsec (danmcd)
• ip module changes (meem, nordmark, sowmini)
• GLDv3 kernel framework (ericc)
• GLDv3 driver changes (ericc, rishi, yun)
• zones related changes (stevelaw)
• TX related changes (wyoung)
• privileges (girishmg)
• SMF (girishmg)
• bfu, packaging, Makefiles (TBD)

 Below is a breakdown of the changes organized by file:

• usr/src/cmd/
  • cmd-inet/usr.sbin/6to4relay.c
  • cmd-inet/usr.sbin/ifconfig
  • cmd-inet/usr.sbin/in.rarpd.c
  • cmd-inet/usr.sbin/snoop
  • devfsadm/misc_link.c
  • dladm
  • dlmgmtd
  • mdb/common/modules/mac/mac.c
  • svc/milestone/net-init
  • svc/milestone/net-iptun
  • svc/milestone/net-physical
  • svc/milestone/network-initial.xml
  • svc/milestone/network-iptun.xml
  • truss/codes.c
  • zoneadm
  • zoneadmd
• usr/src/head/
  • zone.h
• usr/src/lib/
  • brand/native/zone/config.xml
  • brand/native/zone/platform.xml
  • libc/port/sys/zone.c
  • libdladm
  • libdlpi
  • libinetcfg
  • libinetutil
• usr/src/pkgdefs/
  • SUNWckr
  • SUNWcsr
  • common_files/i.minorperm_*
  • etc/exception_list_*
• usr/src/tools/
  • scripts/bfu.sh
• usr/src/ucbhead/
  • sys/types.h
• usr/src/uts/common/fs/
  • dev/sdev_netops.c
• usr/src/uts/common/inet/ip/
  • 6to4tun.c, atun.c, tun.c
  • ip*.c
  • sadb.c, spd.c, spdsock.c
• usr/src/uts/common/inet/iptun/
  • iptun.c, iptun_ctl.c, iptun_dev.c
  • iptundummy*.*
• usr/src/uts/common/io/dld
  • dld_drv.c, dld_flow.c
  • dld_proto.c, dld_str.c
• usr/src/uts/common/io/aggr
• usr/src/uts/common/io/dls
• usr/src/uts/common/io/simnet
• usr/src/uts/common/io/softmac
• usr/src/uts/common/io/vnic
• usr/src/uts/common/io/ib
• usr/src/uts/common/io/mac
  • mac.c, mac_client.c, mac_provider.c
  • mac_flow.c
  • plugins/mac_6to4.c
  • plugins/mac_ipv4.c
  • plugins/mac_ipv6.c
• usr/src/uts/common/os/
  • policy.c, priv_defs
  • zone.c
• usr/src/uts/common/sys/