Brussels II aka ipadm(1M) Code-Review

Welcome to the Brussels II - ipadm/libipadm code-review. Comments should be sent to brussels-dev@opensolaris.org before 22nd Jan 2010. 

Webrev is here: http://cr.opensolaris.org/~girishmg/ipadm-cr

For those who have access to Sun's internal network, a code-review repo along with cscope database is available at /net/zhadum.east/export/ws/ipadm/ipadm-cr/webrev

Design Document is here: http://hub.opensolaris.org/bin/download/Project+brussels/files/brussels2design.pdf
Man Page is here: http://hub.opensolaris.org/bin/download/Project+brussels/files/ipadm.1m.txt

Reviewers may wish to focus on a specific area to narrow down their review. Below is a suggested breakdown of the changes organized by file:

CLI changes

• ifconfig, ndd changes (Mark Haywood, Peter Memishian)
  
  • usr/src/cmd/cmd-inet/usr.sbin/Makefile
  • usr/src/cmd/cmd-inet/usr.sbin/ifconfig/Makefile
  • usr/src/cmd/cmd-inet/usr.sbin/ifconfig/ifconfig.c
  • usr/src/cmd/cmd-inet/usr.sbin/ndd.c

• ipadm, netstart changes (Rishi Srivatsavai, Anurag Maskey)
  
  • usr/src/cmd/cmd-inet/usr.sbin/ipadm/Makefile
  • usr/src/cmd/cmd-inet/usr.sbin/ipadm/ipadm.c
  • usr/src/cmd/cmd-inet/usr.sbin/ipadm/ipadm.xcl
  • usr/src/cmd/cmd-inet/usr.sbin/netstart.c
  • usr/src/cmd/truss/codes.c

Library Changes

• libinetcfg changes (Mark Haywood)
  
  • usr/src/lib/libinetcfg/Makefile.com
  • usr/src/lib/libinetcfg/common/inetcfg.c

• libipadm changes (Peter Memishian, Sebastien Roy, Cathy Zhou)
  
  • usr/src/lib/Makefile
  • usr/src/Makefile.lint
  • usr/src/Targetdirs
  • usr/src/lib/libipadm/Makefile
  • usr/src/lib/libipadm/Makefile.com
  • usr/src/lib/libipadm/i386/Makefile
  • usr/src/lib/libipadm/libipadm.xcl
  • usr/src/lib/libipadm/sparc/Makefile
    (Interface and Address Management) - Peter memishian and Cathy Zhou
  • usr/src/lib/libipadm/common/ifaddrs.h
  • usr/src/lib/libipadm/common/ipadm_addr.c
  • usr/src/lib/libipadm/common/ipadm_if.c
  • usr/src/lib/libipadm/common/ipadm_ndpd.c
  • usr/src/lib/libipadm/common/ipadm_ndpd.h
  • usr/src/lib/libipadm/common/libipadm.c
  • usr/src/lib/libipadm/common/libipadm.h
  • usr/src/lib/libipadm/common/libipadm_impl.h
  • usr/src/lib/libipadm/common/llib-lipadm
  • usr/src/lib/libipadm/common/mapfile-vers
    (Property Management and Daemon interaction) - Sebastien Roy
  • usr/src/lib/libipadm/common/ipadm_persist.c
  • usr/src/lib/libipadm/common/ipadm_prop.c
  • usr/src/lib/libipadm/common/ipadm_ipmgmt.c
  • usr/src/lib/libipadm/common/ipadm_ipmgmt.h

Daemon changes

• New daemon ipmgmtd (Alan maguire, Cathy Zhou)
  
  • usr/src/cmd/cmd-inet/lib/Makefile
  • usr/src/cmd/cmd-inet/lib/ipmgmtd/Makefile
  • usr/src/cmd/cmd-inet/lib/ipmgmtd/ipadm.conf
  • usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_door.c
  • usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_impl.h
  • usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_main.c
  • usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_persist.c
  • usr/src/cmd/cmd-inet/lib/ipmgmtd/ipmgmt_util.c

• in.ndpd, rcm_daemon changes (Sebastien Roy)
  
  • usr/src/cmd/cmd-inet/usr.lib/in.ndpd/Makefile
  • usr/src/cmd/cmd-inet/usr.lib/in.ndpd/defs.h
  • usr/src/cmd/cmd-inet/usr.lib/in.ndpd/main.c
  • usr/src/cmd/cmd-inet/usr.lib/in.ndpd/ndp.c
  • usr/src/cmd/cmd-inet/usr.lib/in.ndpd/tables.c
  • usr/src/cmd/cmd-inet/usr.lib/in.ndpd/tables.h
  • usr/src/cmd/rcm_daemon/Makefile.com
  • usr/src/cmd/rcm_daemon/common/ip_rcm.c

SMF & BFU changes (Sebastien Roy)

usr/src/cmd/cmd-inet/lib/ipmgmtd/net-ipmgmt
usr/src/cmd/cmd-inet/lib/ipmgmtd/network-ipmgmt.xml
usr/src/cmd/svc/milestone/net-loopback
usr/src/cmd/svc/milestone/net-physical
usr/src/cmd/svc/milestone/network-loopback.xml
usr/src/cmd/svc/seed/Makefile
usr/src/tools/scripts/bfu.sh

Security and packaging (Paul Wernau)

usr/src/cmd/Adm/sun/passwd
usr/src/cmd/Adm/sun/shadow
usr/src/cmd/cmd-inet/usr.sbin/in.ftpd/ftpusers
usr/src/cmd/initpkg/inittab
usr/src/tools/protocmp/stdusers.c
usr/src/uts/common/sys/param.h
usr/src/lib/libsecdb/auth_attr.txt
usr/src/lib/libsecdb/exec_attr.txt
usr/src/lib/libsecdb/help/auths/Makefile
usr/src/lib/libsecdb/help/auths/NetworkInterfaceConfig.html
usr/src/lib/libsecdb/prof_attr.txt
usr/src/pkgdefs/SUNW0on/prototype_com
usr/src/pkgdefs/SUNWcnetr/prototype_com
usr/src/pkgdefs/SUNWcslr/prototype_com
usr/src/pkgdefs/SUNWcsr/postinstall
usr/src/pkgdefs/SUNWcsr/prototype_com
usr/src/pkgdefs/SUNWcsu/prototype_com
usr/src/pkgdefs/SUNWhea/prototype_com
usr/src/pkgdefs/common_files/i.ftpusers
usr/src/pkgdefs/common_files/i.passwd
usr/src/pkgdefs/common_files/i.shadow
usr/src/pkgdefs/etc/exception_list_i386
usr/src/pkgdefs/etc/exception_list_sparc

getifaddrs changes (Erik Nordmark)

usr/src/lib/libsocket/Makefile.com
usr/src/lib/libsocket/common/mapfile-vers
usr/src/lib/libsocket/inet/getifaddrs.c

Kernel changes:

• ip changes (Erik Nordmark, Kacheong Poon)
  
  • usr/src/uts/common/Makefile.files
  • usr/src/uts/common/inet/Makefile
  • usr/src/uts/common/inet/ip.h
  • usr/src/uts/common/inet/ip/ip.c
  • usr/src/uts/common/inet/ip/ip_if.c
  • usr/src/uts/common/inet/ip/ip_mroute.c
  • usr/src/uts/common/inet/ip/ip_rts.c
  • usr/src/uts/common/inet/ip/ip_tunables.c
  • usr/src/uts/common/inet/ip_if.h
  • usr/src/uts/common/inet/ip_stack.h
  • usr/src/uts/common/net/if.h
  • usr/src/uts/common/sys/sockio.h

• udp/tcp/sctp changes (Venu Iyer, Kacheong Poon)
  
  • usr/src/uts/common/inet/nd.c
  • usr/src/uts/common/inet/sctp/sctp.c
  • usr/src/uts/common/inet/sctp/sctp_impl.h
  • usr/src/uts/common/inet/sctp/sctp_ioc.c
  • usr/src/uts/common/inet/sctp/sctp_param.c
  • usr/src/uts/common/inet/sctp/sctp_stack.h
  • usr/src/uts/common/inet/sctp/sctp_tunables.c
  • usr/src/uts/common/inet/tcp/tcp.c
  • usr/src/uts/common/inet/tcp/tcp_tunables.c
  • usr/src/uts/common/inet/tcp_impl.h
  • usr/src/uts/common/inet/tcp_stack.h
  • usr/src/uts/common/inet/tunables.c
  • usr/src/uts/common/inet/tunables.h
  • usr/src/uts/common/inet/udp/udp.c
  • usr/src/uts/common/inet/udp/udp_tunables.c
  • usr/src/uts/common/inet/udp_impl.h
  • usr/src/uts/intel/ip/ip.global-objs.debug64
  • usr/src/uts/intel/ip/ip.global-objs.obj64
  • usr/src/uts/sparc/ip/ip.global-objs.debug64
  • usr/src/uts/sparc/ip/ip.global-objs.obj64