Heads-up: new webrev
Date: Thu, 14 Dec 2006 16:44:38 -0800
From: Dan Price <dp at eng dot sun dot com>
To: onnv-gate at onnv dot eng dot sun dot com, on-all at eng dot sun dot com
Subject: Heads-up: new webrev
If you do not use 'webrev' or 'wx webrev', you can safely ignore this
message. Build machine maintainers are encouraged to update /opt/onbld
tomorrow once this is built by the gatekeepers.
My putback of enhancements to 'webrev', 'wx' and 'wdiff' requires that
you update all of these tools at the same time.
A demonstration of the new webrev is available at
http://cr.grommit.com/~dp/webrev-demo/. A PDF copy of the revised
man page is available there, too.
Users should be aware of some new features:
- You can now run 'webrev' standalone and expect it to "just
work." If you have 'wx' initialized, it will use that. If
not, it'll use Teamware (and soon, Mercurial and Subversion).
- Webrev now emits a GNU-patch compatible patch of the changes and a
PDF version of the codereview.
- An "OpenSolaris" mode is now present: use it via 'wx webrev -O' or
'webrev -O'.
- As might be obvious from the above point, wx now passes arguments
to 'wx webrev' on through to webrev.
- The command line output has changed. Here is a sample:
$ webrev
SCM detected: teamware
File list from: 'wx list -w' ... done
Workspace: /builds/dp/webrev-fixes
Compare against: /ws/onnv-clone
Including: /builds/dp/webrev-fixes/webrev-info
Output to: /builds/dp/webrev-fixes/webrev
Output Files:
usr/src/tools/scripts/webrev.1
patch cdiffs udiffs wdiffs sdiffs frames ps old new
usr/src/tools/scripts/webrev.sh
patch cdiffs udiffs wdiffs sdiffs frames ps old new
Generating PDF: Done.
index.html: Done.
- Teamware-only operation (i.e. when wx is not present) is improved.
For example, you can now easily compare the gate against the clone:
CODEMGR_WS=/ws/onnv-gate webrev -p /ws/onnv-clone -o ~/gatechanges
Additionally, the following other features were added:
- Improved man page
- Common color scheme and visual design
- Delta comments at the top of each file
- Printing support via media=print stylesheets
- Support for generating webrev against previous webrev
- Overhauled command line parsing including new options:
-o <outputdir>
-i <include-file>
-p <compare-against>
-w <wx-file>
-O [OpenSolaris mode]
-l <options to putback>
- Cleaned up and improved index.html page.
- XHTML compliance (or close)
The code has been significantly altered. With such a large amount of
change, and with so many users of webrev in different consolidations,
there will probably be bugs; for those I apologize in advance. Please
let me know as soon as you can if you think you've found one, and I will
work to correct it. The correct product/cat/subcat is
solaris/consolidation/os-net-tools, but please also add me to the
interest list (and don't hesitate to send me mail with questions).
Happy Holidays!
-dp
~--
Daniel Price - Solaris Kernel Engineering - dp at eng dot sun dot com - blogs.sun.com/dp
on 2009/11/20 23:47